RFR: 8272797: Mutex with rank safepoint_check_never imply allow_vm_block [v4]

David Holmes dholmes at openjdk.java.net
Thu Aug 26 06:04:26 UTC 2021


On Wed, 25 Aug 2021 23:07:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> See CR for details.  This essentially makes Mutex that safepoint_check_never imply a NoSafepointVerifier, which is a stronger and simpler invariant.
>> Tested with tier1-6.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove allow_vm_block parameter if safepoint_check_never.

Hi Coleen,

I've put a lengthy comment in the JBS issue explaining how I see this change, but the bottom like is that I think it is a perfectly fine simplification.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5218


More information about the hotspot-dev mailing list