RFR: 8272797: Mutex with rank safepoint_check_never imply allow_vm_block [v5]

Patricio Chilano Mateo pchilanomate at openjdk.java.net
Thu Aug 26 16:21:23 UTC 2021


On Thu, 26 Aug 2021 15:42:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> See CR for details.  This essentially makes Mutex that safepoint_check_never imply a NoSafepointVerifier, which is a stronger and simpler invariant.
>> Tested with tier1-6.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reverse the order of safepoint_check_required and allow_vm_block arguments so that the first can imply the value of the second.  This is good because if we decide to rename the second to something like _allow_safepoint_use instead there's less to change. Also remove default arguments as they are evil.

Looks good to me! Thanks for fixing it.

Patricio

-------------

Marked as reviewed by pchilanomate (Committer).

PR: https://git.openjdk.java.net/jdk/pull/5218


More information about the hotspot-dev mailing list