RFR: 8272838: Move CriticalJNI tests out of tier1 [v2]

David Holmes dholmes at openjdk.java.net
Fri Aug 27 13:20:30 UTC 2021


On Fri, 27 Aug 2021 10:39:53 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> See the bug report for more discussion. These tests are tied in Epsilon and Shenandoah test groups, so I rehashed those a bit. Note there are no `tier2` or `tier3` test groups in Hotspot yet, which means these tests would only run as part of Epsilon and Shenandoah test suites. I would rehash tier2/3 in [JDK-8272914](https://bugs.openjdk.java.net/browse/JDK-8272914), while hooking up more runtime and GC tests there.
>> 
>> Motivational run time improvements:
>> 
>> 
>> $  make run-test TEST=hotspot:tier1
>> 
>> # Before
>> real	8m9.678s
>> user	289m59.304s
>> sys	27m46.347s
>> 
>> # After
>> real	7m53.359s    # 15 seconds saved
>> user	278m49.104s  # 11 minutes saved
>> sys	28m2.516s
>> 
>> 
>> Additional testing:
>>  - [x] Checked `hotspot:tier1` run test lists before/after the patch, the difference is only these two lists
>>  - [x] Some test performance measurements.
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Make sure CriticalJNI tests are in tier2 in both Epsilon and Shenandoah blocks
>  - Merge branch 'master' into JDK-8272838-perf-test-criticaljni
>  - 8272838: Remove CriticalJNI tests from tier1

Marked as reviewed by dholmes (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/5219


More information about the hotspot-dev mailing list