RFR: 8272797: Mutex with rank safepoint_check_never imply allow_vm_block [v6]

Coleen Phillimore coleenp at openjdk.java.net
Fri Aug 27 14:18:44 UTC 2021


> See CR for details.  This essentially makes Mutex that safepoint_check_never imply a NoSafepointVerifier, which is a stronger and simpler invariant.
> Tested with tier1-6.

Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:

 - Merge branch 'master' into never-block
 - Reverse the order of safepoint_check_required and allow_vm_block arguments so that the first can imply the value of the second.  This is good because if we decide to rename the second to something like _allow_safepoint_use instead there's less to change. Also remove default arguments as they are evil.
 - Remove allow_vm_block parameter if safepoint_check_never.
 - Merge branch 'master' into never-block
 - Add simple gtest.
 - 8272797: Mutex with rank safepoint_check_never imply allow_vm_block

-------------

Changes: https://git.openjdk.java.net/jdk/pull/5218/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5218&range=05
  Stats: 133 lines in 40 files changed: 25 ins; 9 del; 99 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5218.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5218/head:pull/5218

PR: https://git.openjdk.java.net/jdk/pull/5218


More information about the hotspot-dev mailing list