RFR: 8270489: Support archived heap objects in EpsilonGC [v5]

[Ioi Lam]

On Tue, 31 Aug 2021 05:46:53 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @shipilev review - fixed whitespaces
>
> src/hotspot/share/cds/filemap.hpp line 601:
> 
>> 599:   }
>> 600: 
>> 601: private:
> 
> Maybe move the public function to the public block before line 567 so that the labels at lines 595 and 601 could be removed.

I think it's better to keep the functions together so you can see the difference between `start_address_as_decoded_with_current_oop_encoding_mode` and `start_address_as_decoded_from_archive`. I've shuffled the code a little to group the two related private methods together.

> src/hotspot/share/cds/heapShared.hpp line 221:
> 
>> 219:   static bool is_in_loaded_heap(uintptr_t o) {
>> 220:     return (_loaded_heap_bottom <= o && o < _loaded_heap_top);
>> 221:   }
> 
> This could be a private function since it is only referenced at line 223.

Fixed.

> test/hotspot/jtreg/runtime/cds/appcds/TestEpsilonGCWithCDS.java line 62:
> 
>> 60:     static String G1 = "-XX:+UseG1GC";
>> 61:     static String Epsilon = "-XX:+UseEpsilonGC";
>> 62:     static String experiment = "-XX:+UnlockExperimentalVMOptions";
> 
> The above could be declared `final`.

Fixed.

> test/lib/jdk/test/lib/cds/CDSOptions.java line 136:
> 
>> 134:     public static void disableRuntimePrefix(String s) {
>> 135:         disabledRuntimePrefixes.add(s);
>> 136:     }
> 
> This could be `private`.

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5074