RFR: 8277372: Add getters for BOT and card table members [v4]
Vishal Chand
duke at openjdk.java.net
Wed Dec 1 09:06:29 UTC 2021
On Tue, 30 Nov 2021 16:12:57 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Vishal Chand has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rename BOTConstants
>
> src/hotspot/share/gc/parallel/objectStartArray.hpp line 52:
>
>> 50: static uint _block_size;
>> 51: static uint _block_size_in_words;
>> 52:
>
> Almost the same naming issue as in the `BlockOffsetTable/SharedArray`; I would prefer if these members (and getters) here were named similarly to the ones there.
> It is true that `ObjectStartArray` and `BlockOffsetTable` are basically the same thing, but any eventual merge is another issue.
Shall these be renamed to osa_card_shift? Something like this?
-------------
PR: https://git.openjdk.java.net/jdk/pull/6570
More information about the hotspot-dev
mailing list