RFR: 8277990: NMT: Remove NMT shutdown capability [v2]

[Zhengyu Gu]

On Thu, 2 Dec 2021 16:23:32 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Nice cleanup.
> 
> You missed a few:
> 
> * test/lib/jdk/test/whitebox/WhiteBox.java, `NMTChangeTrackingLevel`
> * test/lib/sun/hotspot/WhiteBox.java, same

Out of curious, why have two versions?

> 
> Will the removal of WB functions cause incompatibilities with older versions of jtreg (can't imagine it does, just wondering)?
> 
No idea.

> Cheers, Thomas

> src/hotspot/share/services/nmtCommon.hpp line 67:
> 
>> 65:   NMT_off,
>> 66:   NMT_summary,
>> 67:   NMT_detail
> 
> I'm fine with removing the explicit numbers here, but could you please add
> 
> STATIC_ASSERT(off > unknown)
> STATIC_ASSERT(summary > off)
> STATIC_ASSERT(detail > summary)
> 
> somewhere? (Maybe in the cpp file, its not such an eyesore there).

Good idea, fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6640