RFR: 8277372: Add getters for BOT and card table members [v6]
Albert Mingkun Yang
ayang at openjdk.java.net
Fri Dec 3 12:31:13 UTC 2021
On Fri, 3 Dec 2021 12:03:45 GMT, Vishal Chand <duke at openjdk.java.net> wrote:
>> Changed the visibility, added getters and refactored the following:
>>
>> 1. Card Table Members
>> 2. BOT members
>> 3. ObjectStartArray block members
>
> Vishal Chand has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>
> - Merge branch 'master' into JDK-8277372-refactor
> - Rename BOTConstants and ObjectStartArray members to _card_*
> - Rename BOTConstants
> - Merge branch 'master' into JDK-8277372-refactor
> - Refactoring in hotspot/cpu dir
> - Initial patch
Just a very minor comment.
src/hotspot/share/gc/parallel/objectStartArray.cpp line 47:
> 45: // We're based on the assumption that we use the same
> 46: // size blocks as the card table.
> 47: assert((int)_card_size == (int)(CardTable::card_size()), "Sanity");
I think the `int` cast can be dropped; both sides are `uint`.
-------------
Marked as reviewed by ayang (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6570
More information about the hotspot-dev
mailing list