RFR: 8278146: G1: Rework VM_G1Concurrent VMOp to clearly identify it as pause [v2]

[Aleksey Shipilev]

On Mon, 6 Dec 2021 15:33:13 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Review Thomas
>>  - Merge branch 'master' into JDK-8278146-g1-concurrent-vmop
>>  - Whitespace and touchups
>>  - Basic implementation
>
> src/hotspot/share/gc/g1/g1VMOperations.hpp line 91:
> 
>> 89: // Concurrent G1 stop-the-world operations such as remark and cleanup.
>> 90: class VM_G1PauseConcurrent : public VM_Operation {
>> 91: private:
> 
> This `private` visibility specifier could be removed.

Done.

> src/hotspot/share/gc/g1/g1VMOperations.hpp line 91:
> 
>> 89: // Concurrent G1 stop-the-world operations such as remark and cleanup.
>> 90: class VM_G1PauseConcurrent : public VM_Operation {
>> 91: private:
> 
> This `private` visibility specifier could be removed.

Done.

> src/hotspot/share/gc/g1/g1VMOperations.hpp line 103:
> 
>> 101:   virtual void doit_epilogue();
>> 102:   virtual void doit();
>> 103:   virtual void work() = 0;
> 
> Please make `work()` protected - there does not seem to be a need to make it public.

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6677