RFR: 8277990: NMT: Remove NMT shutdown capability [v2]
Aleksey Shipilev
shade at openjdk.java.net
Tue Dec 7 13:49:23 UTC 2021
On Tue, 7 Dec 2021 13:41:08 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> tstuefe's comments
>
> src/hotspot/share/services/mallocTracker.cpp line 263:
>
>> 261:
>> 262: #ifdef ASSERT
>> 263: if (level >= NMT_summary) {
>
> Suggestion:
>
> if (level > NMT_off) {
>
>
> This way, we don't care where `NMT_summary` is in the enum. We enter this code on all paths when NMT is enabled?
Actually, maybe even call to `enabled()` here?
-------------
PR: https://git.openjdk.java.net/jdk/pull/6640
More information about the hotspot-dev
mailing list