Integrated: JDK-8278585: Drop unused code from OSThread

Thomas Stuefe stuefe at openjdk.java.net
Tue Dec 14 05:49:14 UTC 2021


On Sun, 12 Dec 2021 07:12:19 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Gentle cleanup of OSThread, removes some unused functionality. No functional changes.
> 
> - both start proc and start param parameters are unused (when we create threads we always start with `thread_native_entry` as thread procedure). Removed members and constructor arguments (had always been called with NULL)
> - `valid_reposition_failure()` is unused, returns always false on all platforms. Used to return true on Solaris, but I could not find a caller even going back to jdk-8.
> - removed `thread_id_offset`, `thread_id_size`, both had been used at one time by C1 but not anymore.
> - Finally, removed the platform-independent stub for the windows-only `set_interrupted()`; replaced it with WINDOWS_ONLY at the only two places where it is invoked. Matter of taste, but I find this actually clearer than having a single-platform function looking like a generic one.
> 
> Thanks, Thomas

This pull request has now been integrated.

Changeset: 3f9638d1
Author:    Thomas Stuefe <stuefe at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/3f9638d124076019f49eb77bc3ff8b466e4beb53
Stats:     57 lines in 12 files changed: 0 ins; 44 del; 13 mod

8278585: Drop unused code from OSThread

Reviewed-by: dholmes, tschatzl

-------------

PR: https://git.openjdk.java.net/jdk/pull/6809


More information about the hotspot-dev mailing list