RFR: 8278241: Implement JVM SpinPause on linux-aarch64 [v3]

Evgeny Astigeevich duke at openjdk.java.net
Tue Dec 14 12:27:10 UTC 2021


On Tue, 14 Dec 2021 10:56:41 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Evgeny Astigeevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Check if StubRoutines::aarch64::spin_wait() is not null
>
> src/hotspot/os_cpu/linux_aarch64/os_linux_aarch64.cpp line 385:
> 
>> 383: extern "C" {
>> 384:   int SpinPause() {
>> 385:     using spin_wait_func_ptr_t = void (*)();
> 
> I think you'll want `ThreadWXEnable wx(WXExec, thread);` for Apple here.

Sorry, why do we need it here? This is linux-aarch64 implementation of SpinPause.
I think it should in SpinPause in `os_cpu/bsd_aarch64/os_bsd_aarch64.cpp`. Am I right?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6803


More information about the hotspot-dev mailing list