RFR: JDK-8278329: some TraceDeoptimization code not included in PRODUCT build

[Tom Rodriguez]

On Tue, 7 Dec 2021 14:46:05 GMT, Tobias Holenstein <duke at openjdk.java.net> wrote:

> After "JDK-8154011: Make `TraceDeoptimization` a diagnostic flag" some code was not included in the PRODUCT build. 
> 
> Removed all the #ifndef PRODUCT guards around `TraceDeoptimization` checks and made sure to be consistent. 
> 
> The DEOPT PACKING messages were controlled by `PrintDeoptimizationDetails` (develop flag), but DEOPT UNPACKING is controlled by `TraceDeoptimization` (product flag),. Therefore changed DEOPT PACKING messages to be controlled by `TraceDeoptimization` as well. 
> 
> Checked that tests are not affected. Checked on Aurora that performance is not affected.

Thanks for cleaning this up.  I think a one or two things should be moved under PrintDeoptimizationDetails for consistency but I wanted to look more closely at the output before adding my comments.  I'll have some comments up soon.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6746