RFR: 8278793: Interpreter(x64) intrinsify Thread.currentThread() [v2]

[Robbin Ehn]

On Fri, 17 Dec 2021 09:54:28 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Hi Robbin, Looks mostly good, one small comment.

Thanks for having a look!

> src/hotspot/cpu/x86/templateInterpreterGenerator_x86_64.cpp line 456:
> 
>> 454:   // Only IN_HEAP loads require a thread_tmp register
>> 455:   __ access_load_at(T_OBJECT, IN_NATIVE, rax,
>> 456:                     Address(rscratch2, 0), rscratch1, noreg);
> 
> I don't like the hardcoded 0 here. You should use MacroAssembler::resolve_oop_handle() instead. (That has the 0 too, I believe this should be changed to a constant like OopHandle::obj_offset_in_bytes() or so, but that is another story.)

Yes, thanks, agreed, fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6833