RFR: 8278602: CDS dynamic dump may access unloaded classes [v3]

[Ioi Lam]

On Fri, 17 Dec 2021 15:55:12 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:
>> 
>>  - Merge branch 'master' into 8278602-cds-zgc-class-unload-bug
>>  - added test case
>>  - @coleenp and @stefank review comments
>>  - cleaned up code
>>  - add #if INCLUDE_CDS
>>  - Merge branch 'master' into 8278602-cds-zgc-class-unload-bug
>>  - using k->is_loader_alive() is enough
>>  - Added DumpTimeSharedClassTable::iterate() to make sure every iteration goes through EligibleClassIterationHelper
>>  - step1
>
> test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/test-classes/LotsUnloadApp.java line 81:
> 
>> 79:     static String x;
>> 80:     static double d = 123;
>> 81:     static float f = 456;
> 
> Are the above declarations needed? They are not being used.

These are left overs. I've remove them.

> test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/test-classes/LotsUnloadApp.java line 88:
> 
>> 86:     public void doit(Runnable r) {
>> 87:         r.run();
>> 88:     }
> 
> I don't see the above method being called.

I've removed it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6859