RFR: 8260368: [PPC64] GC interface needs enhancement to support GCs with load barriers [v2]

[Roman Kennke]

On Mon, 1 Feb 2021 21:18:54 GMT, Niklas Radomski <github.com+9200663+Quaffel at openjdk.org> wrote:

>> At present, the `needs_frame` flag is used on the ppc platform to determine whether gc barriers must emit a new stack frame (and save the link register, for that matter) or not. With the introduction of load reference barriers, however, this mechansim is no longer sufficient. This holds especially true for compiler stubs as those make heavy use of volatile registers.
>> 
>> To mitigate this, this patch replaces the `needs_frame` flag with a simple enumeration. As the enumerators are incremental, handling the different "register preservation needs" in the actual gc barrier implementations is comparatively (pun intended) easy. 
>> 
>> _This is a preparational change for the ShenandoahGC port to ppc. As such, it may provide some functionality this version doesn't make use of, but that is required for the upcoming change. This way, the scope of the upcoming change is limited to GC-specific functionality; making its review a little easier._
>> 
>> _For the same reason, this patch also introduces patching support for `LIR_Assembler::leal`._
>
> Niklas Radomski has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Fix carg slot offset calculation
>  - Use a distinct magic number in clobber_carg_stack_slots
>  - Use enumeration instead of unsigned int

Looks good!

-------------

Marked as reviewed by rkennke (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2302