Integrated: 8260368: [PPC64] GC interface needs enhancement to support GCs with load barriers

Niklas Radomski github.com+9200663+quaffel at openjdk.java.net
Tue Feb 2 15:57:42 UTC 2021


On Thu, 28 Jan 2021 22:08:17 GMT, Niklas Radomski <github.com+9200663+Quaffel at openjdk.org> wrote:

> At present, the `needs_frame` flag is used on the ppc platform to determine whether gc barriers must emit a new stack frame (and save the link register, for that matter) or not. With the introduction of load reference barriers, however, this mechansim is no longer sufficient. This holds especially true for compiler stubs as those make heavy use of volatile registers.
> 
> To mitigate this, this patch replaces the `needs_frame` flag with a simple enumeration. As the enumerators are incremental, handling the different "register preservation needs" in the actual gc barrier implementations is comparatively (pun intended) easy. 
> 
> _This is a preparational change for the ShenandoahGC port to ppc. As such, it may provide some functionality this version doesn't make use of, but that is required for the upcoming change. This way, the scope of the upcoming change is limited to GC-specific functionality; making its review a little easier._
> 
> _For the same reason, this patch also introduces patching support for `LIR_Assembler::leal`._

This pull request has now been integrated.

Changeset: 0093183b
Author:    Quaffel <niklas.radomski at sap.com>
Committer: Martin Doerr <mdoerr at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/0093183b
Stats:     381 lines in 19 files changed: 174 ins; 18 del; 189 mod

8260368: [PPC64] GC interface needs enhancement to support GCs with load barriers

Reviewed-by: mdoerr, rkennke, goetz

-------------

PR: https://git.openjdk.java.net/jdk/pull/2302


More information about the hotspot-dev mailing list