RFR: JDK-8260926: Trace resource exhausted events unconditionally [v2]
Thomas Stuefe
stuefe at openjdk.java.net
Wed Feb 3 06:39:03 UTC 2021
On Wed, 3 Feb 2021 01:43:25 GMT, David Holmes <dholmes at openjdk.org> wrote:
> Hi Thomas,
>
> Approval in principle, but changes suggested.
>
> Thanks,
> David
Hi David, thanks for looking at this. I changed text and tag as requested.
..Thomas
> src/hotspot/share/prims/jvmtiExport.cpp line 1509:
>
>> 1507: JavaThread *thread = JavaThread::current();
>> 1508:
>> 1509: log_error(os)("Resource Exhausted (%s)", description != nullptr ? description : "no info");
>
> Shouldn't that be `log_error(jvmti)`?
> I'd also suggest the text "Posting Resource Exhausted event: %s" with "unknown" for a null description.
Sure, no problem.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2350
More information about the hotspot-dev
mailing list