RFR: JDK-8260485: Simplify and unify handler vectors in Posix signal code [v2]
Thomas Stuefe
stuefe at openjdk.java.net
Wed Feb 3 07:00:47 UTC 2021
On Wed, 3 Feb 2021 00:42:39 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - Make SavedSignalHandlers use C-heap for its items
>> - Removed display-replaced-handler-logic
>> - Feedback David
>> - Merge
>> - JDK-8260485-signal-handler-improvements
>
> src/hotspot/os/posix/signals_posix.cpp line 842:
>
>> 840: if (sig == SHUTDOWN2_SIGNAL && !isatty(fileno(stdin))) {
>> 841: tty->print_cr("Running in non-interactive shell, %s handler is replaced by shell",
>> 842: os::exception_name(sig, buf, O_BUFLEN)); // When comparing, ignore the SA_RESTORER flag on Linux
>
> What does this comment mean in this context ???
Nothing. This, like the "flags" comment before, must have been accidental paste errors. I went through the patch again, but I hope this was the last one.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2251
More information about the hotspot-dev
mailing list