RFR: JDK-8260485: Simplify and unify handler vectors in Posix signal code [v2]
Thomas Stuefe
stuefe at openjdk.java.net
Wed Feb 3 09:17:49 UTC 2021
On Wed, 3 Feb 2021 00:58:11 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - Make SavedSignalHandlers use C-heap for its items
>> - Removed display-replaced-handler-logic
>> - Feedback David
>> - Merge
>> - JDK-8260485-signal-handler-improvements
>
> Hi Thomas,
>
> Still a few minor comments and queries, but overall it is looking good.
>
> Thanks,
> David
I added a printout to print_signal_handler to print out a message if the expected handler changed. This is the same logic, somewhat abridged, applied at Xcheck:jni.
Only here, it fires whenever we print signal handlers independently from Xcheck:jni. So it gets also displayed in hs-err files or as part of a VM.info jcmd.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2251
More information about the hotspot-dev
mailing list