RFR: 8260355: AArch64: deoptimization stub should save vector registers [v4]
Andrew Haley
aph at redhat.com
Wed Feb 3 09:36:27 UTC 2021
On 2/3/21 7:02 AM, Nick Gasson wrote:
> On Tue, 2 Feb 2021 11:08:46 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>
>>> Nick Gasson has updated the pull request incrementally with one additional commit since the last revision:
>>>
>>> Review comments
>>
>> `RegisterMap`-related changes look good.
>
> @theRealAph are the sharedRuntime_aarch64.cpp changes ok?
I guess so, but the code changes are so complex and delicate it's extremely
hard to tell.
What have you done about stress testing? I guess we need some code that's
repeatedly deoptimized and recompiled millions of times, with continuous
testing. I guess that in order to make sure nothing has regressed, a
bootstrap with DeoptimizeALot would help gain some confidence.
--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
More information about the hotspot-dev
mailing list