RFR: 8260369: [PPC64] Add support for JDK-8200555 [v2]

Martin Doerr mdoerr at openjdk.java.net
Thu Feb 4 13:10:41 UTC 2021


On Thu, 4 Feb 2021 12:53:57 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove duplicate MacroAssembler::MacroAssembler::
>
> LGTM

Thanks for the review!
MacroAssembler::MacroAssembler::PRESERVATION_NONE was a copy&paste bug.
And while fixing it, I noticed that I should use PRESERVATION_NONE in load_field_cp_cache_entry, too, which fits better to the interpreter design on PPC64 where we can usually call C without any save&restore code:
https://github.com/openjdk/jdk/pull/2358/commits/be66f4e533e46549bdfc43019920bcff09c4e49a
Tested by using clobber code and running a benchmark.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2358


More information about the hotspot-dev mailing list