RFR: 8259668: Make SubTasksDone use-once [v2]

Albert Mingkun Yang ayang at openjdk.java.net
Thu Feb 4 19:29:43 UTC 2021


On Thu, 4 Feb 2021 15:00:21 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/gc/shared/workgroup.hpp line 314:
> 
>> 312: 
>> 313:   void all_tasks_completed_impl(uint skipped[], size_t skipped_size) {
>> 314: #ifdef ASSERT
> 
> Please keep the definition of the method into the .cpp file. It's too long. You can use the DEBUG_ONLY macro here to not need to define it in non-assert code.

Revised.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2383


More information about the hotspot-dev mailing list