RFR: 8260019: Move some Thread subtypes out of thread.hpp [v2]

Ioi Lam iklam at openjdk.java.net
Fri Feb 5 02:59:39 UTC 2021


On Thu, 4 Feb 2021 13:46:28 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/compiler/compilerThread.hpp line 2:
>> 
>>> 1: /*
>>> 2:  * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved.
>> 
>> Should a new file only have a single copyright year? I'm not sure what the rule is about splitting existing files but you use a single year in the new cpp files.
>
> I think the rule has been: if it's a new file, it gets a new year.

Hi David, you're correct that I just cut-and-pasted the code; the only exception was I made the `thread_entry` functions member functions.

I don't have a better idea for the file names, either. I'll keep them as is in the patch. Maybe someone else with a better sense for naming could fix our file names in the future.

I fixed the copyright year.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2390


More information about the hotspot-dev mailing list