RFR: JDK-8260485: Simplify and unify handler vectors in Posix signal code [v4]

[Thomas Stuefe]

On Fri, 5 Feb 2021 04:19:02 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Looks good. Thanks for the updates.
> 
> One query for further improvement below. :)
> 
> Thanks,
> David

Thanks for approval, David. Unfortunately I still have a strange build problem on one of our s390 boxes, so this is not done yet.

> src/hotspot/os/posix/signals_posix.cpp line 121:
> 
>> 119:       assert(_sa[sig] == NULL, "Overwriting signal handler?");
>> 120:       _sa[sig] = NEW_C_HEAP_OBJ(struct sigaction, mtInternal);
>> 121:       *_sa[sig] = *act;
> 
> Sorry I missed the fact we weren't actually copying the incoming sigaction struct!

Yes me too, and I'm annoyed by the fact that no tier1 test did catch that. The full jtreg suite would have catched it but it did not run yet since the last commit.

> src/hotspot/os/posix/signals_posix.cpp line 1426:
> 
>> 1424:       LINUX_ONLY(this_flag &= SA_RESTORER_FLAG_MASK;)
>> 1425:       if (this_flag != expected_act->sa_flags) {
>> 1426:         st->print_cr("  *** Flags changed! Consider using jsig library.");
> 
> Can't we easily print the difference in flags?

Sure. I'll change it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2251