RFR: 8259668: Make SubTasksDone use-once [v2]

[Albert Mingkun Yang]

On Fri, 5 Feb 2021 09:34:58 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> An additional (as an extra CR, preexisting) cleanup could be moving more method definitions into the cpp file as they do not seem to be performance critical; but as mentioned, this is fine too.

I think it's best to not to hide the definitions from the caller. The current approach ensures an optimized build will have zero cost from having the assertion; otherwise, the call site needs a `callq` instruction (without LTO), probably insignificant, but a few extra lines in the header is fine, IMO.

> could you sync the description of the CR in the JIRA ...

Done.

Thank you for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2383