RFR: 8258953: AArch64: move NEON instructions to aarch64_neon.ad [v2]

[Dong Bo]

On Thu, 28 Jan 2021 12:09:36 GMT, Dong Bo <dongbo at openjdk.org> wrote:

>> I managed to sort all the instructs and compare them with and without the patch. They are general the same except for some trailing whitespaces and typos you mentioned.
>
>> _Mailing list message from [Andrew Haley](mailto:aph at redhat.com) on [hotspot-dev](mailto:hotspot-dev at openjdk.java.net):_
>> 
>> On 1/28/21 10:40 AM, Ningsheng Jian wrote:
>> 
>> > I see you have fixed this typo, from ushr to usra. I presume original version generates wrong code and produces wrong results for specific case? If so, do you think it deserves a separate fix, e.g. for jdk16?
>> 
>> It does. This patch should change nothing at all, except moving
>> text from A to B.
>> 
>> --
>> Andrew Haley (he/him)
>> Java Platform Lead Engineer
>> Red Hat UK Ltd. <https://www.redhat.com>
>> https://keybase.io/andrewhaley
>> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
> 
> @nsjian @theRealAph Thank you for the comments. I'll raise a seperate PR to fix this right now.
> 
> BTW, since Andrew says we should change nothing at all in this move, do you think we should also do the things below in separtate PRs?
> 1. fix the typo of `vor8B`.
> 2. supporting vector length 4 for `vsraa8B_imm` and `vsrla8B_imm`, vector length 2 for `vsraa4S_imm` and `vsrla4S_imm`.

Updated. The whitespaces mentioned are addressed.
The format typo fix in `vor8B` is kept, other instructions are appended to aarch64_neon.ad.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2273