RFR: JDK-8261302: NMT: Improve malloc site table hashing [v2]
Thomas Stuefe
stuefe at openjdk.java.net
Wed Feb 10 07:42:58 UTC 2021
On Wed, 10 Feb 2021 07:28:33 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
> LGTM, except for the one comment I added (it's not a "must", it's a "please").
Thanks Lucy!
> src/hotspot/share/utilities/nativeCallStack.cpp line 31:
>
>> 29: #include "utilities/nativeCallStack.hpp"
>> 30:
>> 31: static unsigned calculate_hash(address stack[NMT_TrackingStackDepth]) {
>
> I know it doesn't change anything semantically, but I'd like to see the int type specifier.
Sure, I'll change it before pushing.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2473
More information about the hotspot-dev
mailing list