RFR: 8261027: AArch64: Support for LSE atomics C++ HotSpot code [v7]

Andrew Haley aph at openjdk.java.net
Wed Feb 10 18:31:40 UTC 2021


On Wed, 10 Feb 2021 17:19:04 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   #ifdef LINUX for now.
>
> src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp line 30:
> 
>> 28: 
>> 29: #include "runtime/vm_version.hpp"
>> 30: #include "atomic_aarch64.hpp"
> 
> Should be sorted before `#include "runtime/vm_version.hpp"`

Thanks.

> src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp line 52:
> 
>> 50: extern aarch64_atomic_stub_t aarch64_atomic_cmpxchg_4_impl;
>> 51: extern aarch64_atomic_stub_t aarch64_atomic_cmpxchg_8_impl;
>> 52: 
> 
> I don't think you need to duplicate all these declarations here if you include `"atomic_aarch64.hpp"` which already declares all these types and variables.

Thanks, done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2434


More information about the hotspot-dev mailing list