RFR: 8261608: Move common CDS archive building code to archiveBuilder.cpp [v2]

Ioi Lam iklam at openjdk.java.net
Fri Feb 12 04:08:03 UTC 2021


> This is a follow-up to https://git.openjdk.java.net/jdk/pull/2296:
> 
> - Move common code for writing the CDS archive from metaspaceShared.cpp to archiveBuilder.cpp
> 
> - Data structures related to dumping were haphazardly organized in several classes (e.g., `DumpRegions`). We needed various APIs to access them across classes. These should be consolidated in archiveBuilder.cpp and the API should be cleaned up
> 
> - Detailed stats (`DumpAllocStats::print_stats`) were available only for static dump. Refactor the code so they are also printed for dynamic dump

Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:

 - fixed spaces
 - use member initializer list; clean up log message

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2536/files
  - new: https://git.openjdk.java.net/jdk/pull/2536/files/f32c40b6..9582e40f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2536&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2536&range=00-01

  Stats: 48 lines in 1 file changed: 20 ins; 17 del; 11 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2536.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2536/head:pull/2536

PR: https://git.openjdk.java.net/jdk/pull/2536


More information about the hotspot-dev mailing list