RFR: 8261672: Reduce inclusion of classLoaderData.hpp
Coleen Phillimore
coleenp at openjdk.java.net
Fri Feb 12 21:38:39 UTC 2021
On Fri, 12 Feb 2021 19:41:54 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> classLoaderData.hpp is included by about 700 out of 1000 .o files in HotSpot. Most of these are transitively included through klass.hpp, typeArrayKlass.hpp and instanceKlass.hpp.
>
> These headers can be refactored by moving inline functions that depend on ClassLoaderData to xxx.inline.hpp. This reduces the .o files that include classLoaderData.hpp to about 260.
>
> (I also removed a bunch of unnecessary inclusion of classLoader.hpp from a few C files).
>
> Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.
Looks good. I think adding compiledICHolder.inline.hpp is worth doing because performance matters to its caller in compiledMethod.cpp.
-------------
Marked as reviewed by coleenp (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2555
More information about the hotspot-dev
mailing list