RFR: 8261608: Move common CDS archive building code to archiveBuilder.cpp [v2]

[Ioi Lam]

On Fri, 12 Feb 2021 23:13:36 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - fixed spaces
>>  - use member initializer list; clean up log message
>
> src/hotspot/share/memory/archiveBuilder.cpp line 197:
> 
>> 195: 
>> 196:   assert(_current == NULL, "must be");
>> 197:   _current = this;
> 
> These lines used to be at the beginning of the function. Any reasons why they are moved?

I think it's better to set `_current` after the instance has been fully initialized.

> test/hotspot/jtreg/runtime/cds/appcds/LotsOfClasses.java line 53:
> 
>> 51:         opts.addSuffix("-Xlog:gc+region+cds");
>> 52:         //opts.addSuffix("-Xlog:gc+region=trace");
>> 53:         opts.addSuffix("-Xlog:cds=debug");  // test detailed metadata info printing
> 
> Remove the commented line #52?

I removed it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2536