RFR: 8261608: Move common CDS archive building code to archiveBuilder.cpp [v3]
Calvin Cheung
ccheung at openjdk.java.net
Sat Feb 13 05:22:41 UTC 2021
On Sat, 13 Feb 2021 05:04:58 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> This is a follow-up to https://git.openjdk.java.net/jdk/pull/2296:
>>
>> - Move common code for writing the CDS archive from metaspaceShared.cpp to archiveBuilder.cpp
>>
>> - Data structures related to dumping were haphazardly organized in several classes (e.g., `DumpRegions`). We needed various APIs to access them across classes. These should be consolidated in archiveBuilder.cpp and the API should be cleaned up
>>
>> - Detailed stats (`DumpAllocStats::print_stats`) were available only for static dump. Refactor the code so they are also printed for dynamic dump
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>
> review comments by @calvinccheung
Marked as reviewed by ccheung (Reviewer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/2536
More information about the hotspot-dev
mailing list