RFR: 8259668: Make SubTasksDone use-once [v3]
Albert Mingkun Yang
ayang at openjdk.java.net
Tue Feb 16 08:24:39 UTC 2021
On Tue, 16 Feb 2021 06:19:13 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review
>
> I would prefer to see all_tasks_claimed eliminated rather than made more
> precise at the expense of being more complicated. I think the added
> precision doesn't provide enough benefit (vs alternatives like checking once
> in the destructor) to pay the API, usage, and implementation cost. But
> that's matter of opinion, about which Albert feels to the contrary. I think
> this change is an improvement regardless of that question, so won't block on
> that basis.
>
> So looks good.
Thanks for the review.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2383
More information about the hotspot-dev
mailing list