RFR: JDK-8260485: Simplify and unify handler vectors in Posix signal code [v6]

[Gerard Ziemski]

On Mon, 15 Feb 2021 22:40:55 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use universal zero initializer for do_check_signal_periodically
>
> I did not get as far as I hoped today, I'll review more tomorrow.

General comment: I get weird results when I try to run `java -XX:ErrorHandlerTest=2 -version`

With the proposed changes, I get:

oracle at dhcp-10-154-126-49 jdk % ./build/xcode/build/jdk/bin/java -XX:ErrorHandlerTest=2 -version
# To suppress the following error report, specify this argument
# after -XX: or in .hotspotrc:  SuppressErrorAt=/vmError.cpp:1785
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  


[Too many errors, abort]
zsh: abort      ./build/xcode/build/jdk/bin/java -XX:ErrorHandlerTest=2 -version

with several empty lines, which I deleted for compactness, whereas the original code produces:

oracle at Oracles-MacBook-Pro-16 jdk_orig % ./build/xcode/build/jdk/bin/java -XX:ErrorHandlerTest=2 -version
# To suppress the following error report, specify this argument
# after -XX: or in .hotspotrc:  SuppressErrorAt=/vmError.cpp:1785
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (/Volumes/Work/review/2251/jdk_orig/src/hotspot/share/utilities/vmError.cpp:1785), pid=69509, tid=7427
#  guarantee(how == 0) failed: test guarantee
#
# JRE version: OpenJDK Runtime Environment (17.0) (fastdebug build 17-internal+0-adhoc.oracle.jdkorig)
# Java VM: OpenJDK 64-Bit Server VM (fastdebug 17-internal+0-adhoc.oracle.jdkorig, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, bsd-amd64)
# No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /Volumes/Work/review/2251/jdk_orig/hs_err_pid69509.log
#
# If you would like to submit a bug report, please visit:
#   https://bugreport.java.com/bugreport/crash.jsp
#
zsh: abort      ./build/xcode/build/jdk/bin/java -XX:ErrorHandlerTest=2 -version

so something is off.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2251