RFR: 8261846: [JVMCI] c2v_iterateFrames can get out of sync with the StackFrameStream

Tom Rodriguez never at openjdk.java.net
Wed Feb 17 19:37:41 UTC 2021


On Wed, 17 Feb 2021 02:33:02 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Update copyright year in vframe.hpp.
>> Otherwise good.
>
> Hi Tom.  This code could be simplified and made faster using vframeStream as the iterator and vframeStream:asJavaVFrame to get the vframe.  If you don't need the locals of every frame, then vframeStream::next is faster than vframe::sender.  See JDK-8214329.

@dean-long I think it would be possible to rewrite this to use vframeStream though it would still need to build vframes because of the introspection it does on compiled frames.  It would be a major rewrite though and in general this code is working just fine so I don't think I want to tackle that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2594


More information about the hotspot-dev mailing list