RFR: 8261649: AArch64: Optimize LSE atomics in C++ code [v2]

[Andrew Haley]

On Thu, 18 Feb 2021 16:58:39 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5655:
>> 
>>> 5653:       acquire = false, release = false; break;
>>> 5654:     default:
>>> 5655:       acquire = true, release = true; break;
>> 
>> I think hotspot style is to indent the `case`-s. Also commas in `acquire` and `release` assignments look weird. Consider:
>> 
>>     Register prev = r3;
>>     Register ptr = c_rarg0;
>>     Register compare_val = c_rarg1;
>>     Register exchange_val = c_rarg2;
>> 
>>     bool acquire, release;
>>     switch (order) {
>>       case memory_order_relaxed:
>>         acquire = false;
>>         release = false;
>>         break;
>>       default:
>>         acquire = true;
>>         release = true; 
>>         break;
>>     }
>
> Oh noes! I'll have to change my emacs indentation setup. I may be gone some time...

Ha! Turns out it's an emacs FAQ: (c-set-offset 'case-label '+)

-------------

PR: https://git.openjdk.java.net/jdk/pull/2611