RFR: JDK-8261552: s390: MacroAssembler::encode_klass_not_null() may produce wrong results for non-zero values of narrow klass base [v2]

[Lutz Schmidt]

On Mon, 22 Feb 2021 10:31:45 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Lucys proposal
>>  - Revert first attempt
>
> src/hotspot/cpu/s390/macroAssembler_s390.cpp line 3635:
> 
>> 3633:   if (base != NULL) {
>> 3634:     // Use scaled-down base address parts to match scaled-down klass pointer.
>> 3635:     unsigned int base_h = ((unsigned long)base)>>(32+shift);
> 
> base_h is unused, but referred to in the comments

There was a comment crossing...
With my latest suggestion, base_h is now used.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2595