RFR: 8256417: Exclude TestJFRWithJMX test from running with PodMan

Igor Ignatyev iignatyev at openjdk.java.net
Thu Feb 25 19:29:39 UTC 2021


On Thu, 25 Feb 2021 19:20:00 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:

>> Please review this small change that excludes the TestJFRWithJMX test from execution on Podman.
>> In summary, this test requires capabilities that are not available under "rootless" podman.
>> What was done:
>>   - added an at-requires method to return the name of the container engine
>>   - using the above named at requires to exclude this test as described above
>
> @hseigel  @iignatev Could you please take a look?

Hi Misha,

so this test can't be run w/ `podman` only if the test-user doesn't have root-level privileges? if so, I think it's better to check if we really don't have such priviliges and throw `SkippedException` (e.g. the same way we do in `SATestUtils` via `Platform.isRoot`). that way, the test will still be runnable in some configurations.

-- Igor

-------------

PR: https://git.openjdk.java.net/jdk/pull/2726


More information about the hotspot-dev mailing list