RFR: 8260198: TypeInstPtr::dump2() emits multiple lines if Verbose is set [v8]

Xin Liu xliu at openjdk.java.net
Thu Feb 25 20:19:41 UTC 2021


On Wed, 24 Feb 2021 11:08:58 GMT, Evgeny Astigeevich <github.com+42899633+eastig at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8260198: TypeInstPtr::dump2() emits multiple lines if Verbose is set
>>   
>>   add comments and hoist ResourceMark
>
> src/hotspot/share/opto/type.cpp line 4053:
> 
>> 4051:       const_oop()->print_oop(&ss);
>> 4052:       // suppress new-lines('\n') in ss emitted by const_oop->print_oop()
>> 4053:       // so each node is one-liner for -XX:+Verbose && -XX:+PrintIdeal
> 
> What about rewriting the comment in clearer way:
> // 'const_oop->print_oop()' emits new-lines('\n') into ss.
> // For -XX:+Verbose && -XX:+PrintIdeal, new-lines('\n') must be removed from
> // the ss created string to have a node per line.

update it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2178


More information about the hotspot-dev mailing list