RFR: 8262227: Change SystemDictionary::find() to return an InstanceKlass*.

Harold Seigel hseigel at openjdk.java.net
Thu Feb 25 21:18:42 UTC 2021


On Thu, 25 Feb 2021 21:12:28 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Please review this fix for JDK-8262227.  This fix changes SystemDictionary::find() to return an InstanceKlass* to reduce InstanceKlass casts, it renames find() to find_instance_klass(), removes its unneeded TRAP parameter, and changes its callers as appropriate.
>> 
>> It also changed the get_java_...() methods, in thread.cpp, to take an InstanceKlass* parameter and removed their now unneeded TRAPS parameter.
>> 
>> The fix was tested with mach5 tiers 1 and 2 on Linux, Windows, and Mac OS, and tiers 3-5 on Linux x64 (still in progress).
>> 
>> Thanks to Coleen and David for their helpful suggestions.
>> 
>> Thanks, Harold
>
> Marked as reviewed by iklam (Reviewer).

Thanks Ioi, Coleen, and David for the reviews!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2712


More information about the hotspot-dev mailing list