RFR: 8256417: Exclude TestJFRWithJMX test from running with PodMan
Igor Ignatyev
iignatyev at openjdk.java.net
Thu Feb 25 22:38:38 UTC 2021
On Thu, 25 Feb 2021 20:50:03 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:
> Igor, while following your suggestion of using jtreg.SkippedException, I am thinking about keeping the new VMProps.containerEngine() in the VMProps.java. It can come in handy in the future. I hope you do not mind that.
generally speaking, I am no fan of adding things we don't use. instead, I'd suggest you creating Platform::containerEngine (or better Container::engine) and it in the test. and if/when the needs for `@requiers container.engine` appears, we can add one w/ almost zero effort.
PS you need to update copyright year in all the updated files.
-- Igor
-------------
PR: https://git.openjdk.java.net/jdk/pull/2726
More information about the hotspot-dev
mailing list