RFR: 8262443: GenerateOopMap::do_interpretation can spin for a long time.

[Coleen Phillimore]

On Fri, 26 Feb 2021 08:50:38 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

> With Safepoint/Handshake timeout enabled in rare cases this methods spins for a long time, blocking safepoints/handshakes, so timeout (with a long delay) is triggered.
> 
> In some cases we are in native while executing this method and in some in vm.
> That's why there is an check for state in vm.
> 
> Tested with other changes in t-1-7 this specific case of timeout is no longer an issue.
> This change-set passes T1 stand alone.

This seems legit.  This can be called by the compiler thread while in native, or during GC or during the rewriter if jsr/ret is found.  I assume the last case is what you observed?

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2742