RFR: 8258032: Reconsider LEAF entry restrictions [v2]

[Coleen Phillimore]

On Wed, 6 Jan 2021 16:40:17 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix copyrights.
>
> src/hotspot/share/c1/c1_Runtime1.cpp line 647:
> 
>> 645:   address pc = thread->exception_pc();
>> 646:   // Still in Java mode
>> 647:   nmethod* nm = NULL;
> 
> You are definitely going to want a C1 cognizant person to
> review the changes in this file. The baseline's use of
> ResetNoHandleMark and NoHandleMark in this file is an
> absolute mess.
> 
> I don't understand the reason for old L647 here and for
> old L652 below. Double ResetNoHandleMarks, but why?
> I see no reason for old L647 so glad that it's gone!

These ResetNoHandleMarks have been there since before mercurial.  I don't see any reason for the ResetNoHandleMark here historically either, since there isn't a NoHandleMark outside this call.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1846