RFR: 8259375: JvmtiExport::jni_Get/SetField_probe calls do not need ResetNoHandleMark
Coleen Phillimore
coleenp at openjdk.java.net
Thu Jan 7 17:16:55 UTC 2021
On Thu, 7 Jan 2021 16:59:30 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
>> This is a trivial change to remove the comments and the ResetNoHandleMark from jvmti functions. They're called by JNI_ENTRY so they don't have a NoHandleMark that needs to be reset. It may not have always been the case.
>> Tested with the other patch for https://bugs.openjdk.java.net/browse/JDK-8258032 and retesting with tier1-3.
>
> This appears to match what I reviewed in JDK-8258032
> so this extraction from that PR looks good. I agree that
> this is a trivial change.
>
> Thumbs up!
Yes, it is a piece of that change. Thanks for the review Dan and Lois!
-------------
PR: https://git.openjdk.java.net/jdk/pull/1975
More information about the hotspot-dev
mailing list