RFR: 8258838: Remove JVM option UseStackBanging [v2]

Harold Seigel hseigel at openjdk.java.net
Mon Jan 11 14:35:01 UTC 2021


On Fri, 8 Jan 2021 21:44:51 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java line 256:
>> 
>>> 254:     public final int stackShadowPages = getFlag("StackShadowPages", Integer.class);
>>> 255:     public final int stackReservedPages = getFlag("StackReservedPages", Integer.class, 0, JDK >= 9);
>>> 256:     public final int stackBias = getConstant("STACK_BIAS", Integer.class, 0, JDK < 15);
>> 
>> The line should be modified instead of removal:
>> public final boolean useStackBanging = getFlag("UseStackBanging", Boolean.class, true, JDK < 17);
>> @dougxc please note that it should be upstreamed when GraalVM adopt JDK 17.
>
> The good thing is that the VM will fail fail when initializing Graal if the update is not done so there's no way we can overlook it.

fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/1988


More information about the hotspot-dev mailing list