RFR: 8258838: Remove JVM option UseStackBanging [v3]

Coleen Phillimore coleenp at openjdk.java.net
Mon Jan 11 14:51:01 UTC 2021


On Mon, 11 Jan 2021 14:04:45 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Thanks Vladimir and Doug for looking at this change!  Please review this latest version that contains the changes requested by Vladimir.
>> Thanks, Harold
>
>> Thanks Vladimir and Doug for looking at this change! Please review this latest version that contains the changes requested by Vladimir.
>> Thanks, Harold
> 
> Changes look good.

The stack banging code still seems like the most efficient way to test for stack overflow in compiled code, but it may be that a pointer comparison in the interpreter entries (that are very inconsistent right now) would be better for them.  There are some cleanup RFEs. eg. https://bugs.openjdk.java.net/browse/JDK-8069196 or even https://bugs.openjdk.java.net/browse/JDK-8072070 if you want them @TheRealMDoerr they're all yours.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1988


More information about the hotspot-dev mailing list