RFR: 8259486: Replace PreserveExceptionMark with implementation for CautiouslyPreserveExceptionMark [v3]

[Coleen Phillimore]

On Mon, 11 Jan 2021 01:26:00 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix wrong JavaThread::active in fill_in_stack_trace.
>
> Hi Coleen,
> 
> AFAICS you are not simply removing CautiouslyPreserveExceptionMark but you are changing PreserveExceptionMark to now act as CautiouslyPreserveExceptionMark  did. If the PEM now encounters an unexpected exception it is no longer fatal. This relaxation is not unreasonable but I think the bug synopsis and description need to be updated to reflect what you are actually doing.
> 
> I agree "Cautiously" was not a good word for distinguishing the two responses here. I also think WeakPEM is not great either. :(
> 
> A couple of minor comments elsewhere.
> 
> Thanks,
> David

Reran tier1-3 and jvmti tests separately (thought the JavaThread::active() was added for them but it couldn't have been because it was added in 1998).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2007