Integrated: 8258810: Improve enum traits
Kim Barrett
kbarrett at openjdk.java.net
Tue Jan 12 03:42:24 UTC 2021
On Tue, 22 Dec 2020 18:45:31 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> Please review these miscellaneous improvements to the enum iteration facility.
> Thanks to @albertnetymk for discussions.
>
> (1) Removed some unneeded stuff from EnumIterationTraits.
>
> (2) Various similar bits of error checking code are unified and shared via
> EnumIterationTraits.
>
> (3) Casts between the enum type and the underlying type are now done using
> helper functions in EnumIterationTraits.
>
> (4) JDK-8257466 added accessors for the EnumRange bounds and the index for
> an enumerator, but didn't account for the possibility of an empty subrange.
> Add assertions for that case.
>
> (5) Added some death tests to verify some of the error checking.
>
> Testing:
> mach5 tier1
This pull request has now been integrated.
Changeset: 2255ab76
Author: Kim Barrett <kbarrett at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/2255ab76
Stats: 106 lines in 2 files changed: 78 ins; 8 del; 20 mod
8258810: Improve enum traits
Reviewed-by: ayang, iklam, lfoltan
-------------
PR: https://git.openjdk.java.net/jdk/pull/1868
More information about the hotspot-dev
mailing list