RFR: 8259629: aarch64 builds fail after JDK-8258932
Vladimir Kozlov
kvn at openjdk.java.net
Tue Jan 12 20:14:00 UTC 2021
On Tue, 12 Jan 2021 18:53:35 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> This fixes aarch64 builds failure after JDK-8258932.
>> It is caused by the mismatched call `fmaxp/fminp` in `AssemblerAArch64` tests to the definitions in `assembler_aarch64.hpp`.
>>
>> Verified with `gtest-1.8.1` and `make test TEST="gtest"`, `linux-aarch64-server-slowdebug`.
>> Both builds and tests are good, the results of `gtest` on my aarch64 server:
>> Finished running test 'gtest:all/server'
>> Test report is stored in build/linux-aarch64-server-slowdebug/test-results/gtest_all_server
>>
>> ==============================
>> Test summary
>> ==============================
>> TEST TOTAL PASS FAIL ERROR
>> gtest:all/server 807 807 0 0
>> ==============================
>> TEST SUCCESS
>>
>> Finished building target 'test' in configuration 'linux-aarch64-server-slowdebug'
>>
>> The `gtest` was not configured during tests in `JDK-8258932`, so it did not execute previously.
>> I'm really sorry for my carelessness and producing a serious BUG.
>
> It passed out whole tier1 testing I ran. So I am fine with it,
>
> But I would like to see review from someone familiar with Aaarch64 assembler too.
After internal discussion and urgency we suggest to push this fix ASAP.
@dgbo please integrate it and I will sponsor.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2052
More information about the hotspot-dev
mailing list